HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525

PDavid · 2024-12-10T09:19:14Z

This is the backport of #6490 for branch-2.5.

As these are not present anymore in v4.

Reason: to make sure that they are the same size (this under thrift was smaller).

This is the latest non-vulnerable version.

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

to make the UI coloring look similar to what we had before.

to make sure the current active navbar link is highlighted appropriately.

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

Make sure background color is visible in tables (Tasks) where alert class is used.

PDavid · 2024-12-10T10:44:52Z

Test failures seems to be unrelated.

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

Apache-HBase · 2024-12-11T15:16:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 51s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	jshint	0m 0s		jshint was not available.
+0 🆗	shelldocs	0m 0s		Shelldocs was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 1s		branch-2.5 passed
+1 💚	compile	5m 35s		branch-2.5 passed
+1 💚	checkstyle	1m 21s		branch-2.5 passed
+1 💚	spotbugs	14m 12s		branch-2.5 passed
-1 ❌	spotless	0m 44s		branch has 1 errors when running spotless:check, run spotless:apply to fix.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	4m 30s		the patch passed
+1 💚	compile	4m 47s		the patch passed
+1 💚	javac	4m 47s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 57s		the patch passed
+1 💚	shellcheck	0m 0s		No new issues.
+1 💚	spotbugs	17m 23s		the patch passed
+1 💚	hadoopcheck	25m 42s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚	spotless	0m 58s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	1m 5s		The patch does not generate ASF License warnings.
		86m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6525
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless jshint shellcheck shelldocs
uname	Linux 323cc74f49a3 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `8f248f1`
Default Java	Eclipse Adoptium-11.0.23+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count	179 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T21:52:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 53s		branch-2.5 passed
+1 💚	compile	1m 58s		branch-2.5 passed
+1 💚	javadoc	3m 1s		branch-2.5 passed
+1 💚	shadedjars	5m 18s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 40s		the patch passed
+1 💚	compile	2m 0s		the patch passed
+1 💚	javac	2m 0s		the patch passed
+1 💚	javadoc	2m 59s		the patch passed
+1 💚	shadedjars	5m 18s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	445m 36s	/patch-unit-root.txt	root in the patch failed.
		478m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6525
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 1332294b6fa5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `8f248f1`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/testReport/
Max. process+thread count	5047 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T22:07:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
-0 ⚠️	yetus	0m 7s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 46s		branch-2.5 passed
+1 💚	compile	1m 57s		branch-2.5 passed
+1 💚	javadoc	3m 25s		branch-2.5 passed
+1 💚	shadedjars	5m 15s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 13s		the patch passed
+1 💚	compile	1m 59s		the patch passed
+1 💚	javac	1m 59s		the patch passed
+1 💚	javadoc	3m 4s		the patch passed
+1 💚	shadedjars	4m 52s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	467m 18s	/patch-unit-root.txt	root in the patch failed.
		502m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6525
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 87b0dfb9f42a 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `8f248f1`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/testReport/
Max. process+thread count	4812 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-11T23:29:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 6s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 15s		branch-2.5 passed
+1 💚	compile	1m 41s		branch-2.5 passed
+1 💚	javadoc	4m 13s		branch-2.5 passed
+1 💚	shadedjars	5m 38s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 25s		the patch passed
+1 💚	compile	2m 10s		the patch passed
+1 💚	javac	2m 10s		the patch passed
+1 💚	javadoc	4m 56s		the patch passed
+1 💚	shadedjars	5m 24s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	546m 48s	/patch-unit-root.txt	root in the patch failed.
		584m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6525
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 6f0f589dd56f 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `8f248f1`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/testReport/
Max. process+thread count	4770 (vs. ulimit of 30000)
modules	C: hbase-resource-bundle hbase-http hbase-server hbase-thrift hbase-rest . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6525/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid added 19 commits December 9, 2024 16:54

HBASE-28832 Removed bootstrap-theme.min.css and Glyphicons icon font

0bd8e54

As these are not present anymore in v4.

HBASE-28832 Upgrade to Bootstrap 4

165af74

HBASE-28832 Migrated Log Level forms

a1478e9

HBASE-28832 Migrated REST web UI pages

b35e42e

HBASE-28832 Migrated canary status page navbar

d43f46c

HBASE-28832 Migrated Thrift UI pages

8e9b8ce

HBASE-28832 Replaced hbase_logo_small.png with hbase-server one

3756345

Reason: to make sure that they are the same size (this under thrift was smaller).

HBASE-28832 Upgraded Bootstrap to 5.3.3

d011259

This is the latest non-vulnerable version.

HBASE-28832 Migrated navbars

3d51dca

- Navbars now require a container within (to drastically simplify spacing requirements and CSS required). - The .active class can no longer be applied to .nav-items, it must be applied directly on .nav-links.

HBASE-28832 Migrated data attributes

b3fc354

Data attributes for all Bootstrap JavaScript plugins are now namespaced to help distinguish Bootstrap functionality from third parties and your own code. For example, we use data-bs-toggle instead of data-toggle.

HBASE-28832 Migrated inline forms - Log levels, table.jsp

7e75432

Breaking change in Bootstrap 5: Dropped form-specific layout classes for our grid system. Use our grid and utilities instead of .form-group, .form-row, or .form-inline.

HBASE-28832 Fixed checkstyle warnings

2ec8308

HBASE-28832 Preserve original HBase UI colors

3560bf6

to make the UI coloring look similar to what we had before.

HBASE-28832 Restore active navbar link background-color

22eba1a

to make sure the current active navbar link is highlighted appropriately.

HBASE-28832 Migrated pagination in jqSpager.js

fd95a61

(used by the "Regions in Transition" section on master status page) so that the paginator links are styled and displayed properly.

HBASE-28832 Avoid double bottom borders with tables in tab contents

d7c34b1

Before the tab content has its own bottom border and table row also had its own bottom border. This resulted in having two lines in all table boundaries. Fix is to remove the bottom border of the table row.

HBASE-28832 Fixed Tasks table row background colors were not visible

e803c9c

Make sure background color is visible in tables (Tasks) where alert class is used.

HBASE-28832 Added missing favicon for Thrift UI

ecfa523

HBASE-28832 Added container-fluid div to REST and thrift navbars

f87e217

This comment has been minimized.

Sign in to view

PDavid marked this pull request as ready for review December 10, 2024 10:44

PDavid mentioned this pull request Dec 10, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6490

Open

PDavid added 2 commits December 11, 2024 14:20

HBASE-28832 Fixed unstyled pager link in jqSpager.js

db1ed86

HBASE-28832 Styled Actions forms on Table Details page

8f248f1

So that buttons and textfields are displayed properly. Also removes unneeded inline styles.

PDavid marked this pull request as draft December 19, 2024 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525

PDavid commented Dec 10, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

PDavid commented Dec 10, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525

Are you sure you want to change the base?

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6525

Conversation

PDavid commented Dec 10, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

PDavid commented Dec 10, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

Apache-HBase commented Dec 11, 2024

PDavid commented Dec 10, 2024 •

edited

Loading